6.0.0-git
2024-04-26

Diff for HordeGroupAPI between 10 and 11

[[toc]]

+ Horde Group API

This document is intended to clarify the Horde Group API, and to provide a solid target for applications to move toward for Horde4.  Motivation for this document was spurred from the conversation between the Bens on IRC regarding the "proper" way to handle groups with LDAP.

----

++ Abstract

In its simplest terms a group consists of an ID and a Name.  The ID is unique to that group and is unchanging.  The name is a human-friendly name that can be changed as desired.  The source and/or format of the group ID should not be of concern to the application using it, and should always be obtained/modified/stored through the group API calls.  The group ID is the **only** acceptable method as to refer to a group, as it is guaranteed to be unique (uniqueness being the job of the driver).  The group name is strictly for interface use.

++ Functional Changes
Horde 4 will deviate from Horde 3 in these key ways:

* The groups collection will be flat.  Groups cannot be created as children of existing groups.

* Groups can belong to other groups.  In this way complex collections of users can be expressed without duplication.
----

++ Standards

In order to help keep concepts straight, the following standards should be used

* **$gid** -- Group ID
* **$group** -- Group Object
* **$grp_drv** -- Group backend driver
* **$name** -- Group Name
* **$parent** -- ID of Group's Parent

----

++ Horde_Group_Backend
This is the class that does the work of reading from/saving to the group storage backend.

+++ create($name)

Creates a new group and returns a new Horde_Group object.

* Add handlers for $name and $parent parameters from newGroup()

+++ renameGroup($gid, $newName)

Changes the name of a group without affecting its membership list
Should probably be private.  This method exists for the instantiated Horde_Group objects to perform backend operations.  Application code should work with Horde_Group objects.

+++ removeGroup($gid)

Removes a group from the groups system permanently.
Should probably be private.  This method exists for the instantiated Horde_Group objects to perform backend operations.  Application code should work with Horde_Group objects.

+++ getByName($name)

Returns a Horde_Group object based on $name

If the name does not match exactly 1 group (too few or too many) it will raise Horde_Group_Exception with an appropriate error message

+++ getById($gid)

Returns Horde_Group object based on the $gid.

+++ exists($gid)

Boolean: Check if a group exists in the system.

+++ listGroups()

Returns an array of all groups, in the format gid => name.

+++ listUsers($gid, $recurse = false)

Get a list of every user that is a part of this group ONLY.

If $recurse is true then also check member groups' user list.

* Add support to take over listAllUsers()

+++ getGroupMembership($user, $parentGroups = false)

Returns an array of Horde_Group objects representing the user's membership

+++ userIsInGroup($user, $gid, $subgroups = true)

Say if a user is a member of a group or not.

+++ @@+++ addUser($username, $gid) @@

Add a user to a group.

* Should be able to handle arrays for both parameters.
Should probably be private.  This method exists for the instantiated Horde_Group objects to perform backend operations.  Application code should work with Horde_Group objects.

+++ @@+++ removeUser($username, $gid) @@

Remove a user from a group.
Should probably be private.  This method exists for the instantiated Horde_Group objects to perform backend operations.  Application code should work with Horde_Group objects.

* Should be able to handle arrays for both parameters.


+++ @@--- newGroup($name, $parent = DATATREE_ROOT) @@++ Horde_Group

deprecated in favor of using addGroup()This object represents a group

+++ @@--- getGroup($gid) @@id()

deprecated -- no longer using group objects.+++ addUser($username)

+++ @@--- getGroupById($gid) @@removeUser($username)

deprecated -- no longer using group objects.+++ listUsers($recurse = true)

Note: This is used in a (small) number of places, most important among those is probably the Horde base API.  There are a couple methods, (
addGroupPermissions(), removeGroupPermissions()) which use it.  This brings up a greater point: We probably want to have a way to allow external entities to interact with our groups via the API methods.  However this probably necessitates a way to look up group IDs (rather than requiring them to know our internal Group IDs).  I believe this method can be done correctly, but it does need to be better defined.  Today, the DataTree driver allows passing in a Groups object, an array, or a string.  The array is join()ed with ':' to produce a string which is used to look up the Group ID.  Whatever happens, we must be able to design method which does not have an ambiguous return value.+++ delete()

+++ @@--- getGroupShortName($group) @@rename()

deprecated -- no need for short names...they're just confusing (K.I.S.S)

+++ @@--- getGroupId($group) @@

deprecated -- no longer using group objects.

+++ @@--- getGroupParents($gid) @@

deprecated in favor of always using flat lists.

+++ @@--- getGroupParentList($gid) @@

deprecated in favor of getGroupParent()

+++ @@--- listAllUsers($gid) @@

deprecated in favor of listUsers()

+++ @@--- getLevel($gid) @@

deprecated -- This is only used in the group admin UI for the tree.  Horde_Tree automatically determines node depth now, so this is no longer necessary.

+++ @@--- updateGroup($group) @@

deprecated -- All group modifications are saved to the backend on the fly.

+++ @@--- getAuditLog($gid) @@

deprecated -- Only used internally to store group to backend.

+++ @@--- clearAuditLog($gid) @@

deprecated -- Only used internally to store group to backend.


++ @@--- !DatatreeObject_Group @@

All !DatatreeObject_Group functionality has been moved to Group (Horde_Groups) to eliminate OO overhead.

+++ setGroupOb(&$groupOb)

+++ getId()

+++ save()

+++ addUser($username, $update = true)

+++ removeUser($username, $update = true)

+++ listUser()

+++ listAllUsers()

+++ getAuditLog()

+++ clearAuditLog()

----

++ Horde_Groups API

This is a list of the methods that will be available in Horde_Groups to Horde4 applications:

* addGroup($name, $parent)
* removeGroup($gid)
* renameGroup($gid, $newName)
* getGroupname($gid)
* getGUID($gid)
* exists($gid)
* getGroupParent($gid, $deep = false)
* listGroups()
* listUsers($gid, $subgroups = false)
* getGroupMembership($username, $parents = false)
* userIsInGroup($username, $gid, $subgroups = true)
* addUser($username, $gid)
* removeUser($username, $gid)