Tickets :: [#6394] Freebusy.php: Fix wrong return value

6.0.0-git

2024-04-25

Summary	Freebusy.php: Fix wrong return value
Queue	Kolab
Type	Bug
State	Resolved
Priority	1. Low
Owners	wrobel (at) horde (dot) org
Requester	thomas.jarosch (at) intra2net (dot) com
Created	2008-03-07 (5893 days ago)
Due
Updated	2008-03-11 (5889 days ago)
Assigned	2008-03-07 (5893 days ago)
Resolved	2008-03-07 (5893 days ago)
Milestone
Patch	No

2008-03-11 13:29:23	thomas (dot) jarosch (at) intra2net (dot) com	Comment #6	Reply to this comment
I believe generate() should always return a vCal object. If it is empty and the upstream code has a problem with that, I'll need to deal with that upstream. In CVS. Looks good, that's the proper solution. Thanks.

2008-03-11 10:20:50	Gunnar Wrobel	Comment #5	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] Another option would be to remove the empty check completely: I'm currently debugging why I'm getting an error from Kolab's "pfb.php" for an empty calendar folder. The reason is the empty check -> no calendar.pvc file get's created. Guess the code is in there to clean up removed calendars, though this was the wrong fix IMHO. I'll investigate further... I believe generate() should always return a vCal object. If it is empty and the upstream code has a problem with that, I'll need to deal with that upstream. In CVS.

2008-03-07 13:07:09	thomas (dot) jarosch (at) intra2net (dot) com	Comment #4	Reply to this comment
Another option would be to remove the empty check completely: I'm currently debugging why I'm getting an error from Kolab's "pfb.php" for an empty calendar folder. The reason is the empty check -> no calendar.pvc file get's created. Guess the code is in there to clean up removed calendars, though this was the wrong fix IMHO. I'll investigate further...

2008-03-07 12:59:47	thomas (dot) jarosch (at) intra2net (dot) com	Comment #3	Reply to this comment
Thanks! Slightly fixed and commited to CVS. Something still looks wrong: The return value of generate() is listed as "string". If all is fine the function returns the $vCal variable which is of type Horde_iCalendar, right? What about either returning Horde_iCalendar or "false" if the calendar is empty?

2008-03-07 12:57:07	Gunnar Wrobel	State ⇒ Resolved

2008-03-07 12:41:34	Gunnar Wrobel	Comment #2	Reply to this comment
Thanks! Slightly fixed and commited to CVS.

2008-03-07 11:05:56	Jan Schneider	Assigned to Gunnar Wrobel State ⇒ Assigned

2008-03-07 11:00:22	thomas (dot) jarosch (at) intra2net (dot) com	Comment #1 Type ⇒ Bug State ⇒ Unconfirmed Priority ⇒ 1. Low Summary ⇒ Freebusy.php: Fix wrong return value Queue ⇒ Kolab New Attachment: framework-kolab-fix-return-value.patch	Reply to this comment
Hello together, attached patch fixes a wrong return value which should be a string instead of an array (returned by listEvents()). Cheers, Thomas